Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
to-promptemitted raw SKILL.md body inside a<![CDATA[ ... ]]>block, allowing a crafted]]>in SKILL.md to break out of CDATA and inject XML nodes.Description
scripts/skills-refthe SKILL.md body is now sanitized by splitting CDATA terminators:]]>→]]]]><![CDATA[>and the script emits thesafeCdatavalue instead of the raw body.tests/fixtures/cdata-terminator/SKILL.mdcontaining an example CDATA-terminator payload.tests/run-tests.shwithtest_to_prompt_cdata_safetywhich runsskills-ref to-prompton the fixture and fails if injected XML appears outside the CDATA block.Testing
./tests/run-tests.shand all tests passed (All tests passed: 7/7)../scripts/skills-ref to-prompt tests/fixtures/cdata-terminatorto verify the CDATA terminator is split and no injected XML appears outside CDATA.Codex Task